Full Version : Got a crash need some help
xmlspawner >>Scripting Support >>Got a crash need some help
<< Prev | Next >>
Erica- 04-25-2007
Hi i got a crash ill post the debug crash

CODE
Mobiles: 8016 Items: 101836 Exception: System.IndexOutOfRangeException: Index was outside the bounds of the array. at Server.Items.Aquarium.GiveReward(Mobile to) in c:\Documents and Settings\Ruben Ocasio\Desktop\RunUO 2.0 SVN 171 ML\Scripts\CustomScripts\Mondain's Legacy\Items\Aquarium\Aquarium.cs:line 529
at Server.Items.Aquarium.CollectRewardEntry.OnClick() in c:\Documents and Settings\Ruben Ocasio\Desktop\RunUO 2.0 SVN 171 ML\Scripts\CustomScripts\Mondain's Legacy\Items\Aquarium\Aquarium.cs:line 792
at Server.Network.PacketHandlers.ContextMenuResponse(NetState state, PacketReader pvSrc)
at Server.Network.PacketHandlers.ExtendedCommand(NetState state, PacketReader pvSrc)
at Server.Network.MessagePump.HandleReceive(NetState ns)
at Server.Network.MessagePump.Slice()
at Server.Core.Main(String[] args)
Clients:

and heres the script

CODE
using System; using System.Collections; using System.Collections.Generic; using Server; using Server.Items;
using Server.Mobiles;
using Server.Multis;
using Server.Gumps;
using Server.ContextMenus;
namespace Server.Items
{
public class Aquarium : BaseAddonContainer
{
// items info
private int m_LiveCreatures;
[CommandProperty( AccessLevel.GameMaster )]
public int LiveCreatures
{
get{ return m_LiveCreatures; }
}
[CommandProperty( AccessLevel.GameMaster )]
public int DeadCreatures
{
get
{
int dead = 0;
for ( int i = 0; i < Items.Count; i ++ )
{
if ( Items[ i ] is BaseFish )
{
BaseFish fish = (BaseFish) Items[ i ];
if ( fish.Dead )
dead += 1;
}
}
return dead;
}
}
[CommandProperty( AccessLevel.GameMaster )]
public int MaxLiveCreatures
{
get
{
int state = m_Food.State == (int) FoodState.Overfed ? 1 : (int) FoodState.Full - m_Food.State;
state += (int) WaterState.Strong - m_Water.State;
state = (int) Math.Pow( state, 1.75 );
return MaxItems - state;
}
}
[CommandProperty( AccessLevel.GameMaster )]
public bool IsFull
{
get{ return Items.Count >= MaxItems; }
}
// vacation info
private int m_VacationLeft;
[CommandProperty( AccessLevel.GameMaster )]
public int VacationLeft
{
get{ return m_VacationLeft; }
set{ m_VacationLeft = value; InvalidateProperties(); }
}
// aquarium state
private AquariumState m_Food;
private AquariumState m_Water;
[CommandProperty( AccessLevel.GameMaster )]
public AquariumState Food
{
get{ return m_Food; }
}
[CommandProperty( AccessLevel.GameMaster )]
public AquariumState Water
{
get{ return m_Water; }
}
[CommandProperty( AccessLevel.GameMaster )]
public bool OptimalState
{
get{ return m_Food.State == (int) FoodState.Full && m_Water.State == (int) WaterState.Strong; }
}
// events
private List<int> m_Events;
private bool m_RewardAvailable;
private bool m_EvaluateDay;
public List<int> Events
{
get{ return m_Events; }
}
[CommandProperty( AccessLevel.GameMaster )]
public bool RewardAvailable
{
get{ return m_RewardAvailable; }
set{ m_RewardAvailable = value; InvalidateProperties(); }
}
// evaluate timer
private Timer m_Timer;
public override BaseAddonContainerDeed Deed
{
get
{
if ( ItemID == 0x3060 )
return new AquariumEastDeed();
else
return new AquariumEastDeed();
}
}
public Aquarium( int itemID ) : base( itemID )
{
if ( itemID == 0x3060 )
AddComponent( new AddonContainerComponent( 0x3061 ), -1, 0, 0 );
if ( itemID == 0x3062 )
AddComponent( new AddonContainerComponent( 0x3063 ), 0, -1, 0 );
MaxItems = 30;
Weight = 10.0;
m_Food = new AquariumState();
m_Water = new AquariumState();
m_Food.State = (int) FoodState.Full;
m_Water.State = (int) WaterState.Strong;
m_Food.Maintain = Utility.RandomMinMax( 1, 2 );;
m_Food.Improve = m_Food.Maintain + Utility.RandomMinMax( 1, 2 );
m_Water.Maintain = Utility.RandomMinMax( 1, 3 );;
m_Events = new List<int>();
m_Timer = Timer.DelayCall( TimeSpan.FromHours( 24 ), TimeSpan.FromHours( 24 ), new TimerCallback( Evaluate ) );
}
public Aquarium( Serial serial ) : base( serial )
{
}
public override void OnDoubleClick( Mobile from )
{
ExamineAquarium( from );
}
public override bool OnDragDrop( Mobile from, Item dropped )
{
BaseHouse house = BaseHouse.FindHouseAt( this );
if ( house == null || !house.IsCoOwner( from ) )
{
from.SendLocalizedMessage( 1073821 ); // You do not have access to that item for use with the aquarium.
return false;
}
if ( m_VacationLeft > 0 )
{
from.SendLocalizedMessage( 1074427 ); // The aquarium is in vacation mode.
return false;
}
if ( dropped is FishBowl )
{
FishBowl bowl = (FishBowl) dropped;
if ( bowl.Empty )
return false;
if ( AddFish( from, bowl.Fish ) )
bowl.InvalidateProperties();
return false;
}
else if ( dropped is BaseFish )
{
BaseFish fish = (BaseFish) dropped;
if ( !AddFish( from, fish ) )
return false;
}
else if ( dropped is VacationWafer )
{
m_VacationLeft += 7;
((Item) dropped).Delete();
from.SendLocalizedMessage( 1074428, "" + m_VacationLeft ); // The aquarium will be in vacation mode for ~1_DAYS~ days
}
else if ( dropped is AquariumFood )
{
m_Food.Added += 1;
((Item) dropped).Delete();
from.SendLocalizedMessage( 1074259, "" + 1 ); // ~1_NUM~ unit(s) of food have been added to the aquarium.
}
else if ( dropped is BaseBeverage )
{
BaseBeverage beverage = (BaseBeverage) dropped;
if ( beverage.IsEmpty || !beverage.Pourable || beverage.Content != BeverageType.Water )
{
from.SendLocalizedMessage( 500840 ); // Can't pour that in there.
return false;
}
m_Water.Added += 1;
beverage.Quantity -= 1;
from.SendLocalizedMessage( 1074260, "{0}", 1 ); // ~1_NUM~ unit(s) of water have been added to the aquarium.
}
else if ( !AddDecoration( from, dropped ) )
return false;
InvalidateProperties();
from.CloseGump( typeof( AquariumGump ) );
return true;
}
public override void OnChop( Mobile from )
{
for ( int i = 0; i < Items.Count; i ++ )
{
Item item = Items[ i ];
item.MoveToWorld( Location, Map );
if ( item is BaseFish )
{
BaseFish fish = (BaseFish) item;
if ( !fish.Dead )
fish.StartTimer();
}
}
base.OnChop( from );
}
public override void GetProperties( ObjectPropertyList list )
{
base.GetProperties( list );
if ( m_VacationLeft > 0 )
list.Add( 1074430, "{0}", m_VacationLeft ); // Vacation days left: ~1_DAYS
if ( m_Events.Count > 0 )
list.Add( 1074426, "{0}", m_Events.Count ); // ~1_NUM~ event(s) to view!
if ( m_RewardAvailable )
list.Add( 1074362 ); // A reward is available!
list.Add( 1074247, "{0}\t{1}", m_LiveCreatures, MaxLiveCreatures ); // Live Creatures: ~1_NUM~ / ~2_MAX~
if ( DeadCreatures > 0 )
list.Add( 1074248, "{0}", DeadCreatures ); // Dead Creatures: ~1_NUM~
list.Add( 1074249, "{0}", Items.Count - m_LiveCreatures - DeadCreatures ); // Decorations: ~1_NUM~
list.Add( 1074250, "#" + FoodNumber() ); // Food state: ~1_STATE~
list.Add( 1074251, "#" + WaterNumber() ); // Water state: ~1_STATE~
if ( m_Food.State == (int) FoodState.Dead )
list.Add( 1074577, "{0}\t{1}", m_Food.Added, m_Food.Improve ); // Food Added: ~1_CUR~ Needed: ~2_NEED~
else if ( m_Food.State == (int) FoodState.Overfed )
list.Add( 1074577, "{0}\t{1}", m_Food.Added, m_Food.Maintain ); // Food Added: ~1_CUR~ Needed: ~2_NEED~
else
list.Add( 1074253, "{0}\t{1}\t{2}", m_Food.Added, m_Food.Maintain, m_Food.Improve ); // Food Added: ~1_CUR~ Feed: ~2_NEED~ Improve: ~3_GROW~
if ( m_Water.State == (int) WaterState.Dead )
list.Add( 1074578, "{0}\t{1}", m_Water.Added, m_Water.Improve ); // Water Added: ~1_CUR~ Needed: ~2_NEED~
else if ( m_Water.State == (int) WaterState.Strong )
list.Add( 1074578, "{0}\t{1}", m_Water.Added, m_Water.Maintain ); // Water Added: ~1_CUR~ Needed: ~2_NEED~
else
list.Add( 1074254, "{0}\t{1}\t{2}", m_Water.Added, m_Water.Maintain, m_Water.Improve ); // Water Added: ~1_CUR~ Maintain: ~2_NEED~ Improve: ~3_GROW~
list.Add( 1073841, "{0}\t{1}\t{2}", Items.Count, MaxItems, TotalWeight ); // Contents: ~1_COUNT~/~2_MAXCOUNT~ items, ~3_WEIGHT~ stones
}
public override void GetContextMenuEntries( Mobile from, List<ContextMenuEntry> list )
{
base.GetContextMenuEntries( from, list );
if ( from.Alive )
{
list.Add( new ExamineEntry( this ) );
if ( m_RewardAvailable )
list.Add( new CollectRewardEntry( this ) );
if ( m_Events.Count > 0 )
list.Add( new ViewEventEntry( this ) );
if ( m_VacationLeft > 0 )
list.Add( new CancelVacationMode( this ) );
}
if ( (int) from.AccessLevel > (int) AccessLevel.Counselor )
{
list.Add( new GMAddFood( this ) );
list.Add( new GMAddWater( this ) );
list.Add( new GMForceEvaluate( this ) );
list.Add( new GMOpen( this ) );
list.Add( new GMFill( this ) );
}
}
public override void Serialize( GenericWriter writer )
{
base.Serialize( writer );
writer.Write( 0 ); // Version
writer.Write( (int) m_LiveCreatures );
writer.Write( (int) m_VacationLeft );
m_Food.Serialize( writer );
m_Water.Serialize( writer );
writer.Write( (int) m_Events.Count );
for ( int i = 0; i < m_Events.Count; i ++ )
writer.Write( (int) m_Events[ i ] );
writer.Write( (bool) m_RewardAvailable );
}
public override void Deserialize( GenericReader reader )
{
base.Deserialize( reader );
int version = reader.ReadInt();
m_LiveCreatures = reader.ReadInt();
m_VacationLeft = reader.ReadInt();
m_Food = new AquariumState();
m_Water = new AquariumState();
m_Food.Deserialize( reader );
m_Water.Deserialize( reader );
m_Events = new List<int>();
int count = reader.ReadInt();
for ( int i = 0; i < count; i ++ )
m_Events.Add( reader.ReadInt() );
m_RewardAvailable = reader.ReadBool();
}
#region Members
public int FoodNumber()
{
if ( m_Food.State == (int) FoodState.Full )
return 1074240;
if ( m_Food.State == (int) FoodState.Overfed )
return 1074239;
return 1074236 + m_Food.State;
}
public int WaterNumber()
{
return 1074242 + m_Water.State;
}
#endregion
#region Virtual members
public virtual void KillFish( int amount )
{
List<BaseFish> toKill = new List<BaseFish>();
for ( int i = 0; i < Items.Count; i ++ )
{
if ( Items[ i ] is BaseFish )
{
BaseFish fish = (BaseFish) Items[ i ];
if ( !fish.Dead )
toKill.Add( fish );
}
}
while ( amount > 0 )
{
int kill = Utility.Random( toKill.Count );
toKill[ kill ].Kill();
toKill.RemoveAt( kill );
amount -= 1;
m_LiveCreatures -= 1;
if ( m_LiveCreatures < 0 )
m_LiveCreatures = 0;
m_Events.Add( 1074366 ); // An unfortunate accident has left a creature floating upside-down. It is starting to smell.
}
}
public virtual void Evaluate()
{
if ( m_VacationLeft > 0 )
{
m_VacationLeft -= 1;
}
else if ( m_EvaluateDay )
{
// reset events
m_Events = new List<int>();
// food events
if (
( m_Food.Added < m_Food.Maintain && m_Food.State != (int) FoodState.Overfed && m_Food.State != (int) FoodState.Dead ) ||
( m_Food.Added >= m_Food.Improve && m_Food.State == (int) FoodState.Full )
)
m_Events.Add( 1074368 ); // The tank looks worse than it did yesterday.
if (
( m_Food.Added >= m_Food.Improve && m_Food.State != (int) FoodState.Full && m_Food.State != (int) FoodState.Overfed ) ||
( m_Food.Added < m_Food.Maintain && m_Food.State == (int) FoodState.Overfed )
)
m_Events.Add( 1074367 ); // The tank looks healthier today.
// water events
if ( m_Water.Added < m_Water.Maintain && m_Water.State != (int) WaterState.Dead )
m_Events.Add( 1074370 ); // This tank can use more water.
if ( m_Water.Added >= m_Water.Improve && m_Water.State != (int) WaterState.Strong )
m_Events.Add( 1074369 ); // The water looks clearer today.
UpdateFoodState();
UpdateWaterState();
// reward
if ( m_LiveCreatures > 0 && Utility.RandomBool() )
m_RewardAvailable = true;
// new fish
if ( OptimalState && Items.Count < MaxItems )
{
if ( Utility.RandomDouble() < 0.005 * m_LiveCreatures )
{
BaseFish fish = null;
int message = 0;
switch ( Utility.Random( 6 ) )
{
case 0:
message = 1074371; // Brine shrimp have hatched overnight in the tank.
fish = new BrineShrimp();
break;
case 1:
message = 1074365; // A new creature has hatched overnight in the tank.
fish = new Coral();
break;
case 2:
message = 1074365; // A new creature has hatched overnight in the tank.
fish = new FullMoonFish();
break;
case 3:
message = 1074373; // A sea horse has hatched overnight in the tank.
fish = new SeaHorse();
break;
case 4:
message = 1074365; // A new creature has hatched overnight in the tank.
fish = new StrippedFlakeFish();
break;
case 5:
message = 1074365; // A new creature has hatched overnight in the tank.
fish = new StrippedSosarianSwill();
break;
}
if ( Utility.RandomDouble() < 0.05 )
fish.Hue = m_FishHues[ Utility.Random( m_FishHues.Length ) ];
else if ( Utility.RandomDouble() < 0.5 )
fish.Hue = Utility.RandomMinMax( 0x100, 0x3E5 );
m_Events.Add( message );
}
}
// kill fish *grins*
if ( m_LiveCreatures < MaxLiveCreatures )
{
if ( Utility.RandomDouble() < 0.01 )
KillFish( 1 );
}
else
KillFish( m_LiveCreatures - MaxLiveCreatures );
}
m_EvaluateDay = !m_EvaluateDay;
}
public virtual void GiveReward( Mobile to )
{
if ( !m_RewardAvailable )
return;
double max = m_LiveCreatures * ( m_Decorations.Length / (double) MaxLiveCreatures );
int random = (int) Math.Log( 1, Math.Pow( Math.E, max ) );
Type reward = m_Decorations[ random ];
Item item;
try{ item = Activator.CreateInstance( reward ) as Item; }
catch{ return; }
if ( !to.PlaceInBackpack( item ) )
to.SendLocalizedMessage( 1074361 ); // The reward could not be given. Make sure you have room in your pack.
else
{
to.SendLocalizedMessage( 1074360, "#" + item.LabelNumber ); // You receive a reward: ~1_REWARD~
to.PlaySound( 0x5A3 );
}
m_RewardAvailable = false;
InvalidateProperties();
}
public virtual void UpdateFoodState()
{
if ( m_Food.Added < m_Food.Maintain )
m_Food.State = m_Food.State <= 0 ? 0 : m_Food.State - 1;
else if ( m_Food.Added >= m_Food.Improve )
m_Food.State = m_Food.State >= (int) FoodState.Overfed ? (int) FoodState.Overfed : m_Food.State + 1;
m_Food.Maintain = Utility.Random( (int) FoodState.Overfed + 1 - m_Food.State, 2 );
if ( m_Food.State == (int) FoodState.Overfed )
m_Food.Improve = 0;
else
m_Food.Improve = m_Food.Maintain + 2;
m_Food.Added = 0;
}
public virtual void UpdateWaterState()
{
if ( m_Water.Added < m_Water.Maintain )
m_Water.State = m_Water.State <= 0 ? 0 : m_Water.State - 1;
else if ( m_Water.Added >= m_Water.Improve )
m_Water.State = m_Water.State >= (int) WaterState.Strong ? (int) WaterState.Strong : m_Water.State + 1;
m_Water.Maintain = Utility.Random( (int) WaterState.Strong + 2 - m_Water.State, 2 );
if ( m_Water.State == (int) WaterState.Strong )
m_Water.Improve = 0;
else
m_Water.Improve = m_Water.Maintain + 2;
m_Water.Added = 0;
}
public virtual bool RemoveItem( Mobile from, int at )
{
if ( at < 0 && at >= Items.Count )
return false;
Item item = Items[ at ];
if ( item is BaseFish )
{
BaseFish fish = (BaseFish) item;
FishBowl bowl;
if ( (bowl = GetEmptyBowl( from )) != null )
{
bowl.AddItem( fish );
from.SendLocalizedMessage( 1074511 ); // You put the creature into a fish bowl.
}
else
{
if ( !from.PlaceInBackpack( fish ) )
{
from.SendLocalizedMessage( 1074514 ); // You have no place to put it.
return false;
}
else
from.SendLocalizedMessage( 1074512 ); // You put the gasping creature into your pack.
}
if ( !fish.Dead )
m_LiveCreatures -= 1;
}
else
{
if ( !from.PlaceInBackpack( item ) )
{
from.SendLocalizedMessage( 1074514 ); // You have no place to put it.
return false;
}
else
from.SendLocalizedMessage( 1074513 ); // You put the item into your pack.
}
InvalidateProperties();
return true;
}
public virtual void ExamineAquarium( Mobile from )
{
if ( !from.InRange( this, 2 ) )
{
from.Say( 1019045 ); // I can't reach that.
return;
}
BaseHouse house = BaseHouse.FindHouseAt( this );
from.CloseGump( typeof( AquariumGump ) );
if ( house != null && house.IsCoOwner( from ) )
from.SendGump( new AquariumGump( this, true ) );
else
from.SendGump( new AquariumGump( this, false ) );
from.PlaySound( 0x5A4 );
}
public virtual bool AddFish( Mobile from, BaseFish fish )
{
if ( fish == null )
return false;
if ( ( m_LiveCreatures == MaxLiveCreatures && !IsFull ) || fish.Dead )
{
from.SendLocalizedMessage( 1073633 ); // The aquarium can not hold the creature.
return false;
}
AddItem( fish );
fish.StopTimer();
m_LiveCreatures += 1;
from.SendLocalizedMessage( 1073632, "#" + fish.LabelNumber ); // You add the following creature to your aquarium: ~1_FISH~
return true;
}
public virtual bool AddDecoration( Mobile from, Item item )
{
if ( item == null )
return false;
if ( IsFull )
{
from.SendLocalizedMessage( 1073636 ); // The decoration will not fit in the aquarium.
return false;
}
if ( !Accepts( item ) )
{
from.SendLocalizedMessage( 1073822 ); // The aquarium can not hold that item.
return false;
}
AddItem( item );
if ( item.LabelNumber != 0 )
from.SendLocalizedMessage( 1073635, "#" + item.LabelNumber ); // You add the following decoration to your aquarium: ~1_NAME~
else
from.SendLocalizedMessage( 1073635, item.Name ); // You add the following decoration to your aquarium: ~1_NAME~
return true;
}
#endregion
#region Static members
public static FishBowl GetEmptyBowl( Mobile from )
{
if ( from.Backpack == null )
return null;
Item[] items = from.Backpack.FindItemsByType( typeof( FishBowl ) );
for ( int i = 0; i < items.Length; i ++ )
{
if ( items[ i ] is FishBowl )
{
FishBowl bowl = (FishBowl) items[ i ];
if ( bowl.Empty )
return bowl;
}
}
return null;
}
private static Type[] m_Decorations = new Type[]
{
typeof( FishBones ),
typeof( WaterloggedBoots ),
typeof( CaptainBlackheartsFishingPole ),
typeof( CraftysFishingHat ),
typeof( IslandStatue ),
typeof( Shell ),
typeof( ToyBoat )
};
public static bool Accepts( Item item )
{
if ( item == null )
return false;
Type type = item.GetType();
for ( int i = 0; i < m_Decorations.Length; i ++ )
{
if ( type == m_Decorations[ i ] )
return true;
}
return false;
}
private static int[] m_FishHues = new int[]
{
0x1C2, 0x1C3, 0x2A3, 0x47E, 0x51D
};
public static int[] FishHues
{
get{ return m_FishHues; }
}
#endregion
#region Context entries
private class ExamineEntry : ContextMenuEntry
{
private Aquarium m_Aquarium;
public ExamineEntry( Aquarium aquarium ) : base( 6235, 2 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
m_Aquarium.ExamineAquarium( Owner.From );
}
}
private class CollectRewardEntry : ContextMenuEntry
{
private Aquarium m_Aquarium;
public CollectRewardEntry( Aquarium aquarium ) : base( 6237, 2 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
m_Aquarium.GiveReward( Owner.From );
m_Aquarium.InvalidateProperties();
}
}
private class ViewEventEntry : ContextMenuEntry
{
private Aquarium m_Aquarium;
public ViewEventEntry( Aquarium aquarium ) : base( 6239, 2 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
Owner.From.SendLocalizedMessage( m_Aquarium.Events[ 0 ] );
if ( m_Aquarium.Events[ 0 ] == 1074366 )
Owner.From.PlaySound( 0x5A2 );
m_Aquarium.Events.RemoveAt( 0 );
m_Aquarium.InvalidateProperties();
}
}
private class CancelVacationMode : ContextMenuEntry
{
private Aquarium m_Aquarium;
public CancelVacationMode( Aquarium aquarium ) : base( 6240, 2 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
Owner.From.SendLocalizedMessage( 1074429 ); // Vacation mode has been cancelled.
m_Aquarium.VacationLeft = 0;
m_Aquarium.InvalidateProperties();
}
}
// GM context entries
private class GMAddFood : ContextMenuEntry
{
private Aquarium m_Aquarium;
public GMAddFood( Aquarium aquarium ) : base( 6231, -1 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
m_Aquarium.Food.Added += 1;
m_Aquarium.InvalidateProperties();
}
}
private class GMAddWater : ContextMenuEntry
{
private Aquarium m_Aquarium;
public GMAddWater( Aquarium aquarium ) : base( 6232, -1 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
m_Aquarium.Water.Added += 1;
m_Aquarium.InvalidateProperties();
}
}
private class GMForceEvaluate : ContextMenuEntry
{
private Aquarium m_Aquarium;
public GMForceEvaluate( Aquarium aquarium ) : base( 6233, -1 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
m_Aquarium.Evaluate();
m_Aquarium.InvalidateProperties();
}
}
private class GMOpen : ContextMenuEntry
{
private Aquarium m_Aquarium;
public GMOpen( Aquarium aquarium ) : base( 6234, -1 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
Owner.From.SendGump( new AquariumGump( m_Aquarium, true ) );
}
}
private class GMFill : ContextMenuEntry
{
private Aquarium m_Aquarium;
public GMFill( Aquarium aquarium ) : base( 6236, -1 )
{
m_Aquarium = aquarium;
}
public override void OnClick()
{
if ( m_Aquarium.Deleted )
return;
m_Aquarium.Food.Added = m_Aquarium.Food.Maintain;
m_Aquarium.Water.Added = m_Aquarium.Water.Maintain;
m_Aquarium.InvalidateProperties();
}
}
#endregion
}
public class AquariumEastDeed : BaseAddonContainerDeed
{
public override BaseAddonContainer Addon{ get{ return new Aquarium( 0x3060 ); } }
public override int LabelNumber{ get{ return 1074501; } } // Large Aquarium (east)
[Constructable]
public AquariumEastDeed() : base()
{
}
public AquariumEastDeed( Serial serial ) : base( serial )
{
}
public override void Serialize( GenericWriter writer )
{
base.Serialize( writer );
writer.Write( 0 ); // Version
}
public override void Deserialize( GenericReader reader )
{
base.Deserialize( reader );
int version = reader.ReadInt();
}
}
public class AquariumNorthDeed : BaseAddonContainerDeed
{
public override BaseAddonContainer Addon{ get{ return new Aquarium( 0x3062 ); } }
public override int LabelNumber{ get{ return 1074497; } } // Large Aquarium (north)
[Constructable]
public AquariumNorthDeed() : base()
{
}
public AquariumNorthDeed( Serial serial ) : base( serial )
{
}
public override void Serialize( GenericWriter writer )
{
base.Serialize( writer );
writer.Write( 0 ); // Version
}
public override void Deserialize( GenericReader reader )
{
base.Deserialize( reader );
int version = reader.ReadInt();
}
}
}

Any help please where i need to fix this script Thanks.
ArteGordon- 04-27-2007

QUOTE
public virtual void GiveReward( Mobile to ) { if ( !m_RewardAvailable ) return; double max = m_LiveCreatures * ( m_Decorations.Length / (double) MaxLiveCreatures );
int random = (int) Math.Log( 1, Math.Pow( Math.E, max ) );
Type reward = m_Decorations[ random ];

I'm not sure what you are trying to do with your 'random' calculation, but it is not going to behave well and thus cause problems with your indexing into the m_Decorations array.